Skip to content

[Build/Test] Keep kernel smoke fixtures out of package publishing - #802

Merged
brandonpayton merged 1 commit into
mainfrom
gascity/kd-1mr/kd-nacw-kernel-test-fixtures
Jul 23, 2026
Merged

[Build/Test] Keep kernel smoke fixtures out of package publishing#802
brandonpayton merged 1 commit into
mainfrom
gascity/kd-1mr/kd-nacw-kernel-test-fixtures

Conversation

@brandonpayton

@brandonpayton brandonpayton commented Jun 30, 2026

Copy link
Copy Markdown
Member

Why

The small Wasm programs used by kernel and host smoke tests are repository-built test fixtures. They are not distributable packages or Homebrew formulae.

Keeping a kernel-test-programs package manifest made package tooling treat seven unrelated fixtures as one multi-output package. The atomic package resolver would then move their paths into a package directory, even though their real producer and consumers intentionally use the flat test-fixture paths.

What changes

  • Remove kernel-test-programs from the package registry and browser-package exceptions.
  • Add a versioned test-artifact inventory that records each architecture-specific fixture, source, producer, resolver path, and every source consumer.
  • Check that the inventory is complete, paths are safe, sources and consumers exist, and no unrecorded literal consumer appears.
  • Record the old hello.wasm entry as retired; examples/hello.c remains a separate SDK example.
  • Make the worker-entry test request the actual wasm64 hello64 fixture instead of relying on an incorrect wasm32 default-path fallback.
  • Document shared test-artifact ownership under tests/test-artifacts.

This changes test/build ownership only. It does not change the kernel, ABI, host runtime behavior, or production deployment.

Validation

Current-main local validation:

  • package-system suite: 11 files, 89 tests passed
  • focused ownership/browser/fetch tests: 17 tests passed
  • inventory consumer/path audit passed
  • worker-entry test loaded successfully and skipped because this clean worktree had no built fixture bytes
  • git diff --check

The pull request CI will provide exact-head Node, browser, POSIX, libc, Sortix, and staging evidence before merge.

@brandonpayton
brandonpayton force-pushed the gascity/kd-1mr/kd-nacw-kernel-test-fixtures branch from 2c39d54 to e9f8090 Compare July 23, 2026 11:09
@brandonpayton brandonpayton changed the title Move kernel test fixtures out of registry package scope [Build/Test] Keep kernel smoke fixtures out of package publishing Jul 23, 2026
@brandonpayton
brandonpayton marked this pull request as ready for review July 23, 2026 11:10
@brandonpayton brandonpayton added the ready-to-ship Maintainer attests the exact tested head and requests merge preparation. label Jul 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

prepare-merge: test-gate passed against the synthetic PR merge and sealed merge-candidate-abi-v41-pr-802-run-30002852030-attempt-1. The canonical ABI index is unchanged. merge-gate=success was posted on PR HEAD. This PR is ready for a reviewer to squash merge; default-branch reconciliation will verify the exact merged tree before activation.

@brandonpayton
brandonpayton merged commit 427185c into main Jul 23, 2026
60 checks passed
@brandonpayton
brandonpayton deleted the gascity/kd-1mr/kd-nacw-kernel-test-fixtures branch July 23, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-ship Maintainer attests the exact tested head and requests merge preparation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant